Fixes #137 - working dir should be set to something reasonable. #139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…ble. Turns out vscode passes us the cwd. Just needed to rename the property in the LaunchRequest class to match. Same for args (renamed Arguments). I have not hooked up script args yet though.
Contributor Author
| BTW if this goes through I will be updating the package.json to add configurationProperties for cwd and maybe args (if I can figure out how to pass those args to the script reliably) e.g.: "configurationAttributes": { "launch": { "required": [ "program" ], "properties": { "program": { "type": "string", "description": "Workspace relative path to the PowerShell script." }, "args": { "type": "array", "description": "Command line arguments passed to the PowerShell script", "items": { "type": "string" }, "default": [] }, "cwd": { "type": "string", "description": "Workspace relative or absolute path for the working directory. Default is the current workspace.", "default": "." } } } }, "initialConfigurations": [ { "name": "PowerShell", "type": "PowerShell", "request": "launch", "program": "${file}", "args": [], "cwd": "${workspaceRoot}" } ] |
Contributor
| Awesome! I think you can simplify your code a little bit, will leave a comment in the commit |
| | ||
| // /** Launch the debuggee in this working directory (specified as an absolute path). If omitted the debuggee is lauched in its own directory. */ | ||
| public string WorkingDirectory { get; set; } | ||
| public string Cwd { get; set; } |
Contributor
There was a problem hiding this comment.
Apparently they changed this on me a long time ago and I never noticed it...
Also found two launch params that have been renamed (looking at 0.10.7-insiders mono-debug package.json file). Although I don't think runtimeArgs really applies to PowerShell debugging. The "runtimeExecutable" is the debug host and by the time the launch message comes along, it is already started.
Contributor Author
| OK, updated that method as you suggested. |
daviwil added a commit that referenced this pull request Feb 7, 2016
Fixes #137 - working dir should be set to something reasonable.
Contributor
| Fantastic, thanks! Merged it. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Turns out vscode passes us the cwd. Just needed to rename the property in the LaunchRequest class to match. Same for args (renamed Arguments). I have not hooked up script args yet though.
@daviwil - please look over the ExecuteCommand for Set-Location to make sure I'm doing the ContinueWith() correctly.