feat(flags): add evaluation_environments to node and react-native SDKs #2417
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| The latest updates on your projects. Learn more about Vercel for GitHub.
|
dmarticus changed the title dmarticus changed the title ![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| const posthogWithEnvs = new PostHog('TEST_API_KEY', { | ||
| host: 'http://example.com', | ||
| evaluationEnvironments: ['production', 'backend'], | ||
| ...posthogImmediateResolveOptions, |
Contributor
There was a problem hiding this comment.
style: Consider extracting posthogImmediateResolveOptions to a shared constant at the top of the file for better maintainability
Context Used: Context from dashboard - When defining constants, such as template IDs, use a constants file or define them at the top of the... (source)
Prompt To Fix With AI
This is a comment left during a code review. Path: packages/node/src/__tests__/posthog-node.spec.ts Line: 2483:2483 Comment: **style:** Consider extracting `posthogImmediateResolveOptions` to a shared constant at the top of the file for better maintainability **Context Used:** Context from `dashboard` - When defining constants, such as template IDs, use a constants file or define them at the top of the... ([source](https://app.greptile.com/review/custom-context?memory=046b860e-6d45-4e24-be8e-6e1727a1b550)) How can I resolve this? If you propose a fix, please make it concise.| 'http://example.com/flags/?v=2&config=true', | ||
| expect.objectContaining({ | ||
| method: 'POST', | ||
| body: expect.stringContaining('"evaluation_environments":["production","backend"]'), |
Contributor
There was a problem hiding this comment.
style: This string assertion is fragile. Consider using JSON.parse() on the body and asserting against the parsed object structure instead
Prompt To Fix With AI
This is a comment left during a code review. Path: packages/node/src/__tests__/posthog-node.spec.ts Line: 2492:2492 Comment: **style:** This string assertion is fragile. Consider using `JSON.parse()` on the body and asserting against the parsed object structure instead How can I resolve this? If you propose a fix, please make it concise.| expect.stringContaining('/flags/?v=2&config=true'), | ||
| expect.objectContaining({ | ||
| method: 'POST', | ||
| body: expect.stringContaining('"evaluation_environments":["production","mobile"]'), |
Contributor
There was a problem hiding this comment.
style: The test uses string matching on the request body, which could be brittle if the JSON serialization order changes. Consider using JSON.parse() to validate the presence of the field more reliably.
Prompt To Fix With AI
This is a comment left during a code review. Path: packages/react-native/test/posthog.spec.ts Line: 24:24 Comment: **style:** The test uses string matching on the request body, which could be brittle if the JSON serialization order changes. Consider using JSON.parse() to validate the presence of the field more reliably. How can I resolve this? If you propose a fix, please make it concise.| this.disableGeoip = options?.disableGeoip ?? true | ||
| this.disabled = options?.disabled ?? false | ||
| this.historicalMigration = options?.historicalMigration ?? false | ||
| this.evaluationEnvironments = options?.evaluationEnvironments |
Contributor
There was a problem hiding this comment.
syntax: Missing property declaration for evaluationEnvironments. This will cause a TypeScript compilation error since the property is not declared in the class.
Suggested change
| this.evaluationEnvironments = options?.evaluationEnvironments | |
| // Evaluation environments configuration | |
| private evaluationEnvironments?: string[]; | |
| constructor(apiKey: string, options?: PostHogCoreOptions) { | |
| assert(apiKey, "You must pass your PostHog project's api key.") | |
| this.apiKey = apiKey | |
| this.host = removeTrailingSlash(options?.host || 'https://us.i.posthog.com') | |
| this.flushAt = options?.flushAt ? Math.max(options?.flushAt, 1) : 20 | |
| this.maxBatchSize = Math.max(this.flushAt, options?.maxBatchSize ?? 100) | |
| this.maxQueueSize = Math.max(this.flushAt, options?.maxQueueSize ?? 1000) | |
| this.flushInterval = options?.flushInterval ?? 10000 | |
| this.preloadFeatureFlags = options?.preloadFeatureFlags ?? true | |
| // If enable is explicitly set to false we override the optout | |
| this.defaultOptIn = options?.defaultOptIn ?? true | |
| this.disableSurveys = options?.disableSurveys ?? false | |
| this._retryOptions = { | |
| retryCount: options?.fetchRetryCount ?? 3, | |
| retryDelay: options?.fetchRetryDelay ?? 3000, // 3 seconds | |
| retryCheck: isPostHogFetchError, | |
| } | |
| this.requestTimeout = options?.requestTimeout ?? 10000 // 10 seconds | |
| this.featureFlagsRequestTimeoutMs = options?.featureFlagsRequestTimeoutMs ?? 3000 // 3 seconds | |
| this.remoteConfigRequestTimeoutMs = options?.remoteConfigRequestTimeoutMs ?? 3000 // 3 seconds | |
| this.disableGeoip = options?.disableGeoip ?? true | |
| this.disabled = options?.disabled ?? false | |
| this.historicalMigration = options?.historicalMigration ?? false | |
| this.evaluationEnvironments = options?.evaluationEnvironments | |
| // Init promise allows the derived class to block calls until it is ready | |
| this._initPromise = Promise.resolve() | |
| this._isInitialized = true | |
| this.disableCompression = !isGzipSupported() || (options?.disableCompression ?? false) | |
| } |
Prompt To Fix With AI
This is a comment left during a code review. Path: packages/core/src/posthog-core-stateless.ts Line: 166:166 Comment: **syntax:** Missing property declaration for `evaluationEnvironments`. This will cause a TypeScript compilation error since the property is not declared in the class. ```suggestion // Evaluation environments configuration private evaluationEnvironments?: string[]; constructor(apiKey: string, options?: PostHogCoreOptions) { assert(apiKey, "You must pass your PostHog project's api key.") this.apiKey = apiKey this.host = removeTrailingSlash(options?.host || 'https://us.i.posthog.com') this.flushAt = options?.flushAt ? Math.max(options?.flushAt, 1) : 20 this.maxBatchSize = Math.max(this.flushAt, options?.maxBatchSize ?? 100) this.maxQueueSize = Math.max(this.flushAt, options?.maxQueueSize ?? 1000) this.flushInterval = options?.flushInterval ?? 10000 this.preloadFeatureFlags = options?.preloadFeatureFlags ?? true // If enable is explicitly set to false we override the optout this.defaultOptIn = options?.defaultOptIn ?? true this.disableSurveys = options?.disableSurveys ?? false this._retryOptions = { retryCount: options?.fetchRetryCount ?? 3, retryDelay: options?.fetchRetryDelay ?? 3000, // 3 seconds retryCheck: isPostHogFetchError, } this.requestTimeout = options?.requestTimeout ?? 10000 // 10 seconds this.featureFlagsRequestTimeoutMs = options?.featureFlagsRequestTimeoutMs ?? 3000 // 3 seconds this.remoteConfigRequestTimeoutMs = options?.remoteConfigRequestTimeoutMs ?? 3000 // 3 seconds this.disableGeoip = options?.disableGeoip ?? true this.disabled = options?.disabled ?? false this.historicalMigration = options?.historicalMigration ?? false this.evaluationEnvironments = options?.evaluationEnvironments // Init promise allows the derived class to block calls until it is ready this._initPromise = Promise.resolve() this._isInitialized = true this.disableCompression = !isGzipSupported() || (options?.disableCompression ?? false) } ``` How can I resolve this? If you propose a fix, please make it concise.
marandaneto reviewed Oct 9, 2025
marandaneto reviewed Oct 9, 2025
Contributor
Contributor
| Size Change: +468 B (+0.01%) Total Size: 4.81 MB
ℹ️ View Unchanged
|
dmarticus force-pushed the feat/add-evaluation-tags-to-mobile-sdks branch from c634df2 to 78b9c93 Compare dmarticus force-pushed the feat/add-evaluation-tags-to-mobile-sdks branch from 78b9c93 to b403154 Compare 
dustinbyrne approved these changes Oct 10, 2025
marandaneto approved these changes Oct 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Changes
This PR implements support for evaluation environments, allowing users to specify which environment tags their SDK instance should use when evaluating feature flags.
Key changes:
['production', 'web', 'checkout'])/flagsendpoint to includeevaluation_environmentsin the request payload when configuredThis implementation follows the specification outlined in:
When configured, only feature flags that have at least one matching evaluation tag will be evaluated. Feature flags with no evaluation tags will always be evaluated for backward compatibility.
Basically, I'm doing what I did here, in response to a customer request.
This should be perfectly safe; this field is backward compatible and won't affect existing versions of the app.