Skip to content

Allow web deployment value to be configured through values #788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 24, 2024
Merged

Allow web deployment value to be configured through values #788

merged 3 commits into from
Jan 24, 2024
+20 −3

Conversation

@frankh
Copy link
Contributor

@frankh frankh commented Jan 24, 2024

Description

Allow deployment kind+strategy to be customised with values so that we can switch to argo rollouts

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

How has this been tested?

existing tests should pass with no changes
will add tests to verify once a PoC has been deployed in dev

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
@frankh frankh merged commit 207a918 into main Jan 24, 2024
@frankh frankh deleted the frank/web-deployment-type-values branch January 24, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@frankh