Fix worker HPA to target new worker groups #783
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Also fix matchLabel clash between different worker deployments
benjackwhite approved these changes Jan 17, 2024
webjunkie reviewed Jan 17, 2024
Contributor
webjunkie left a comment
webjunkie left a comment There was a problem hiding this comment.
I think these references need to be adjusted.
frankh force-pushed the frank/worker-hpa-fix branch from a65ad2a to ce76fb9 Compare MatchLabels is immutable so easiest workaround is change the deployment names
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Also fix matchLabel clash between different worker deployments
Description
Type of change
How has this been tested?
Checklist