Skip to content

Conversation

@klamas1
Copy link
Contributor

@klamas1 klamas1 commented Nov 9, 2022

Description

Added global options nodeSelector, tolerations and affinity. So that you can nail the entire stack to the necessary nodes with a two of lines in values.
Individual settings can still be set for each deployments.

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

How has this been tested?

helm upgrade --dry-run

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
@klamas1 klamas1 force-pushed the common_nodeSelector_and_tolerations branch from 7188936 to 74ac365 Compare November 9, 2022 22:11
@klamas1 klamas1 force-pushed the common_nodeSelector_and_tolerations branch from 74ac365 to a8e17e7 Compare November 9, 2022 22:21
@JannKleen
Copy link

@klamas1 I'm not sure if this should be a separate issue, but I think the clickhouse-backup cronjob currently has no nodeSelector at all. Maybe here is a good way to add it?

@klamas1 klamas1 force-pushed the common_nodeSelector_and_tolerations branch from d4f1d70 to 2ae7eb2 Compare December 7, 2022 09:33
@klamas1
Copy link
Contributor Author

klamas1 commented Dec 7, 2022

@JannKleenI, have added options to charts/posthog/templates/clickhouse-backup-cronjob.yaml

@klamas1 klamas1 force-pushed the common_nodeSelector_and_tolerations branch 3 times, most recently from 0000d75 to b33d608 Compare January 17, 2023 12:27
@klamas1 klamas1 force-pushed the common_nodeSelector_and_tolerations branch from b33d608 to 3a7606a Compare January 17, 2023 13:54
@klamas1
Copy link
Contributor Author

klamas1 commented Jan 17, 2023

@guidoiaquinti
I propose to merge this request :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants