[ADD] Generic closer #503
Merged
[ADD] Generic closer #503
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a generic closer helper function, ErrorClose, to standardize error logging when closing io.Closers. Additionally, it refactors multiple ddns provider and configuration files to replace inline deferred close functions with calls to ErrorClose.
- Added ErrorClose utility in pkg/logging/logging.go.
- Replaced multiple anonymous deferred close functions throughout ddns providers and config with log.ErrorClose calls.
- Updated files: pkg/logging/logging.go, pkg/ddns/resolver.go, pkg/ddns/providers/requests.go, pkg/ddns/providers/noip.go, pkg/ddns/providers/inwx.go, pkg/ddns/providers/infomaniak.go, pkg/config/config.go.
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/logging/logging.go | Added generic ErrorClose function for closing resources with error logging. |
| pkg/ddns/resolver.go | Replaced deferred close with an immediate call to ErrorClose. |
| pkg/ddns/providers/requests.go | Replaced deferred close with a call to ErrorClose. |
| pkg/ddns/providers/noip.go | Replaced deferred close with a call to ErrorClose. |
| pkg/ddns/providers/inwx.go | Replaced deferred close with a call to ErrorClose. |
| pkg/ddns/providers/infomaniak.go | Replaced deferred close with a call to ErrorClose. |
| pkg/config/config.go | Replaced deferred file close with a call to ErrorClose. |
valentin-kaiser approved these changes Apr 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.