Skip to content

Conversation

@Plaenkler
Copy link
Owner

No description provided.

dependabot bot and others added 28 commits March 3, 2025 01:44
Bumps [github.com/aliyun/alibaba-cloud-sdk-go](https://github.com/aliyun/alibaba-cloud-sdk-go) from 1.63.89 to 1.63.90. - [Release notes](https://github.com/aliyun/alibaba-cloud-sdk-go/releases) - [Changelog](https://github.com/aliyun/alibaba-cloud-sdk-go/blob/master/ChangeLog.txt) - [Commits](aliyun/alibaba-cloud-sdk-go@v1.63.89...v1.63.90) --- updated-dependencies: - dependency-name: github.com/aliyun/alibaba-cloud-sdk-go dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
…cies/github.com/aliyun/alibaba-cloud-sdk-go-1.63.90 Bump github.com/aliyun/alibaba-cloud-sdk-go from 1.63.89 to 1.63.90
Bumps [github.com/aliyun/alibaba-cloud-sdk-go](https://github.com/aliyun/alibaba-cloud-sdk-go) from 1.63.90 to 1.63.92. - [Release notes](https://github.com/aliyun/alibaba-cloud-sdk-go/releases) - [Changelog](https://github.com/aliyun/alibaba-cloud-sdk-go/blob/master/ChangeLog.txt) - [Commits](aliyun/alibaba-cloud-sdk-go@v1.63.90...v1.63.92) --- updated-dependencies: - dependency-name: github.com/aliyun/alibaba-cloud-sdk-go dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
…cies/github.com/aliyun/alibaba-cloud-sdk-go-1.63.92 Bump github.com/aliyun/alibaba-cloud-sdk-go from 1.63.90 to 1.63.92
Bumps [golang.org/x/time](https://github.com/golang/time) from 0.10.0 to 0.11.0. - [Commits](golang/time@v0.10.0...v0.11.0) --- updated-dependencies: - dependency-name: golang.org/x/time dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
…cies/golang.org/x/time-0.11.0 Bump golang.org/x/time from 0.10.0 to 0.11.0
Bumps [github.com/aliyun/alibaba-cloud-sdk-go](https://github.com/aliyun/alibaba-cloud-sdk-go) from 1.63.92 to 1.63.94. - [Release notes](https://github.com/aliyun/alibaba-cloud-sdk-go/releases) - [Changelog](https://github.com/aliyun/alibaba-cloud-sdk-go/blob/master/ChangeLog.txt) - [Commits](aliyun/alibaba-cloud-sdk-go@v1.63.92...v1.63.94) --- updated-dependencies: - dependency-name: github.com/aliyun/alibaba-cloud-sdk-go dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
…cies/github.com/aliyun/alibaba-cloud-sdk-go-1.63.94 Bump github.com/aliyun/alibaba-cloud-sdk-go from 1.63.92 to 1.63.94
Bumps [github.com/aliyun/alibaba-cloud-sdk-go](https://github.com/aliyun/alibaba-cloud-sdk-go) from 1.63.94 to 1.63.98. - [Release notes](https://github.com/aliyun/alibaba-cloud-sdk-go/releases) - [Changelog](https://github.com/aliyun/alibaba-cloud-sdk-go/blob/master/ChangeLog.txt) - [Commits](aliyun/alibaba-cloud-sdk-go@v1.63.94...v1.63.98) --- updated-dependencies: - dependency-name: github.com/aliyun/alibaba-cloud-sdk-go dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
…cies/github.com/aliyun/alibaba-cloud-sdk-go-1.63.98 Bump github.com/aliyun/alibaba-cloud-sdk-go from 1.63.94 to 1.63.98
Bumps [github.com/aliyun/alibaba-cloud-sdk-go](https://github.com/aliyun/alibaba-cloud-sdk-go) from 1.63.98 to 1.63.99. - [Release notes](https://github.com/aliyun/alibaba-cloud-sdk-go/releases) - [Changelog](https://github.com/aliyun/alibaba-cloud-sdk-go/blob/master/ChangeLog.txt) - [Commits](aliyun/alibaba-cloud-sdk-go@v1.63.98...v1.63.99) --- updated-dependencies: - dependency-name: github.com/aliyun/alibaba-cloud-sdk-go dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
…cies/github.com/aliyun/alibaba-cloud-sdk-go-1.63.99 Bump github.com/aliyun/alibaba-cloud-sdk-go from 1.63.98 to 1.63.99
Bumps [github.com/aliyun/alibaba-cloud-sdk-go](https://github.com/aliyun/alibaba-cloud-sdk-go) from 1.63.99 to 1.63.100. - [Release notes](https://github.com/aliyun/alibaba-cloud-sdk-go/releases) - [Changelog](https://github.com/aliyun/alibaba-cloud-sdk-go/blob/master/ChangeLog.txt) - [Commits](aliyun/alibaba-cloud-sdk-go@v1.63.99...v1.63.100) --- updated-dependencies: - dependency-name: github.com/aliyun/alibaba-cloud-sdk-go dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
…cies/github.com/aliyun/alibaba-cloud-sdk-go-1.63.100 Bump github.com/aliyun/alibaba-cloud-sdk-go from 1.63.99 to 1.63.100
Bumps [golangci/golangci-lint-action](https://github.com/golangci/golangci-lint-action) from 6 to 7. - [Release notes](https://github.com/golangci/golangci-lint-action/releases) - [Commits](golangci/golangci-lint-action@v6...v7) --- updated-dependencies: - dependency-name: golangci/golangci-lint-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
…ndencies/golangci/golangci-lint-action-7 Bump golangci/golangci-lint-action from 6 to 7
Bumps [github.com/aliyun/alibaba-cloud-sdk-go](https://github.com/aliyun/alibaba-cloud-sdk-go) from 1.63.100 to 1.63.101. - [Release notes](https://github.com/aliyun/alibaba-cloud-sdk-go/releases) - [Changelog](https://github.com/aliyun/alibaba-cloud-sdk-go/blob/master/ChangeLog.txt) - [Commits](aliyun/alibaba-cloud-sdk-go@v1.63.100...v1.63.101) --- updated-dependencies: - dependency-name: github.com/aliyun/alibaba-cloud-sdk-go dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
…cies/github.com/aliyun/alibaba-cloud-sdk-go-1.63.101 Bump github.com/aliyun/alibaba-cloud-sdk-go from 1.63.100 to 1.63.101
Bumps [github.com/aliyun/alibaba-cloud-sdk-go](https://github.com/aliyun/alibaba-cloud-sdk-go) from 1.63.101 to 1.63.102. - [Release notes](https://github.com/aliyun/alibaba-cloud-sdk-go/releases) - [Changelog](https://github.com/aliyun/alibaba-cloud-sdk-go/blob/master/ChangeLog.txt) - [Commits](aliyun/alibaba-cloud-sdk-go@v1.63.101...v1.63.102) --- updated-dependencies: - dependency-name: github.com/aliyun/alibaba-cloud-sdk-go dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
…cies/github.com/aliyun/alibaba-cloud-sdk-go-1.63.102 Bump github.com/aliyun/alibaba-cloud-sdk-go from 1.63.101 to 1.63.102
Bumps [github.com/aliyun/alibaba-cloud-sdk-go](https://github.com/aliyun/alibaba-cloud-sdk-go) from 1.63.102 to 1.63.103. - [Release notes](https://github.com/aliyun/alibaba-cloud-sdk-go/releases) - [Changelog](https://github.com/aliyun/alibaba-cloud-sdk-go/blob/master/ChangeLog.txt) - [Commits](aliyun/alibaba-cloud-sdk-go@v1.63.102...v1.63.103) --- updated-dependencies: - dependency-name: github.com/aliyun/alibaba-cloud-sdk-go dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
…cies/github.com/aliyun/alibaba-cloud-sdk-go-1.63.103 Bump github.com/aliyun/alibaba-cloud-sdk-go from 1.63.102 to 1.63.103
Bumps [github.com/aliyun/alibaba-cloud-sdk-go](https://github.com/aliyun/alibaba-cloud-sdk-go) from 1.63.103 to 1.63.104. - [Release notes](https://github.com/aliyun/alibaba-cloud-sdk-go/releases) - [Changelog](https://github.com/aliyun/alibaba-cloud-sdk-go/blob/master/ChangeLog.txt) - [Commits](aliyun/alibaba-cloud-sdk-go@v1.63.103...v1.63.104) --- updated-dependencies: - dependency-name: github.com/aliyun/alibaba-cloud-sdk-go dependency-version: 1.63.104 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
…cies/github.com/aliyun/alibaba-cloud-sdk-go-1.63.104 Bump github.com/aliyun/alibaba-cloud-sdk-go from 1.63.103 to 1.63.104
Bumps [github.com/aliyun/alibaba-cloud-sdk-go](https://github.com/aliyun/alibaba-cloud-sdk-go) from 1.63.104 to 1.63.105. - [Release notes](https://github.com/aliyun/alibaba-cloud-sdk-go/releases) - [Changelog](https://github.com/aliyun/alibaba-cloud-sdk-go/blob/master/ChangeLog.txt) - [Commits](aliyun/alibaba-cloud-sdk-go@v1.63.104...v1.63.105) --- updated-dependencies: - dependency-name: github.com/aliyun/alibaba-cloud-sdk-go dependency-version: 1.63.105 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
…cies/github.com/aliyun/alibaba-cloud-sdk-go-1.63.105 Bump github.com/aliyun/alibaba-cloud-sdk-go from 1.63.104 to 1.63.105
Bumps [github.com/aliyun/alibaba-cloud-sdk-go](https://github.com/aliyun/alibaba-cloud-sdk-go) from 1.63.105 to 1.63.106. - [Release notes](https://github.com/aliyun/alibaba-cloud-sdk-go/releases) - [Changelog](https://github.com/aliyun/alibaba-cloud-sdk-go/blob/master/ChangeLog.txt) - [Commits](aliyun/alibaba-cloud-sdk-go@v1.63.105...v1.63.106) --- updated-dependencies: - dependency-name: github.com/aliyun/alibaba-cloud-sdk-go dependency-version: 1.63.106 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
…cies/github.com/aliyun/alibaba-cloud-sdk-go-1.63.106 Bump github.com/aliyun/alibaba-cloud-sdk-go from 1.63.105 to 1.63.106
@Plaenkler Plaenkler requested a review from Copilot April 21, 2025 09:44
@Plaenkler Plaenkler self-assigned this Apr 21, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the dependency for golangci-lint-action from v6 to v7.

  • Upgraded the action version in the linters workflow to take advantage of the latest improvements.
Files not reviewed (1)
  • go.mod: Language not supported
Comments suppressed due to low confidence (1)

.github/workflows/linters.yml:52

  • Verify that the new v7 version of golangci-lint-action maintains compatibility with the current workflow configuration. Review the v7 release notes for any breaking changes or updated settings that might require further adjustments.
uses: golangci/golangci-lint-action@v7 
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR, titled "[UPD] Dependencies", primarily updates dependency versions and improves error handling across several modules. The changes include enhanced error logging when writing responses, improved deferred resource cleanup with logging, and a dependency update in the linters workflow.

  • Enhanced error handling in HTTP response writing and deferred closures.
  • Standardized usage of string replacement functions.
  • Updated golangci-lint version in CI.

Reviewed Changes

Copilot reviewed 12 out of 13 changed files in this pull request and generated no comments.

Show a summary per file
File Description
pkg/server/routes/web/login.go Updated error handling to log failures when writing response content.
pkg/server/routes/web/index.go Similar error handling improvements and logging adjustments.
pkg/logging/logging.go Replaced deprecated string replacement with ReplaceAll.
pkg/ddns/resolver.go Added error logging when closing response body.
pkg/ddns/providers/requests.go Improved error handling and deferred closing changes; updated error messages.
pkg/ddns/providers/noip.go Added deferred closure error logging for response body.
pkg/ddns/providers/inwx.go Similar deferred closure improvements with logging.
pkg/ddns/providers/infomaniak.go Added logging logic in deferred response body closings.
pkg/ddns/providers/custom.go Replaced strings.Replace with strings.ReplaceAll.
pkg/config/config.go Updated deferred file closing to log errors.
.github/workflows/linters.yml Upgraded the golangci-lint-action from v6 to v7.
Files not reviewed (1)
  • go.mod: Language not supported
Comments suppressed due to low confidence (1)

pkg/ddns/providers/requests.go:43

  • The usage of 'bytes.TrimSpace' may indicate a missing import for the 'bytes' package, which could lead to a compilation error. Consider either adding 'import "bytes"' or using 'strings.TrimSpace' if that was the intended function.
return string(bytes.TrimSpace(body)), nil 
@Plaenkler Plaenkler merged commit e4cdd2f into main Apr 23, 2025
17 checks passed
@Plaenkler Plaenkler removed the request for review from valentin-kaiser April 23, 2025 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant