Skip to content

Conversation

@jverce
Copy link
Contributor

@jverce jverce commented Sep 27, 2020

This PR is in support of issue #412

  • Add Vercel component
  • Add event source logic for New Deployment
  • Add event source logic for Deployment Ready
* Add utility methods to the Vercel app file to create and delete webhooks in projects/repositories. * Add other utility methods to make code clearer.
@jverce jverce added the enhancement New feature or request label Sep 27, 2020
@jverce jverce requested a review from dylburger September 27, 2020 05:53
@jverce jverce self-assigned this Sep 27, 2020
@vercel
Copy link

vercel bot commented Sep 27, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

pipedream-docs – ./docs

🔍 Inspect: https://vercel.com/pipedreamers/pipedream-docs/B3WNc1Yk6xYujZK4ndNfue1u8kzA
✅ Preview: https://pipedream-docs-git-fork-jverce-vercel-new-deployment-pip-b5ee5d.vercel.app

pipedream-docs-redirect-do-not-edit – ./docs

🔍 Inspect: https://vercel.com/pipedreamers/pipedream-docs-redirect-do-not-edit/59UHrskPCcEWhP9Bcq1wFApPfXGF
✅ Preview: https://pipedream-docs-git-fork-jverce-vercel-new-deployment-pip-2d17ce.vercel.app

@jverce jverce linked an issue Sep 30, 2020 that may be closed by this pull request
@jverce jverce added the blocked Issue is blocked pending a resolution label Oct 8, 2020
@jverce jverce closed this Dec 24, 2020
@jverce jverce deleted the vercel-new-deployment branch December 24, 2020 21:30
@jverce jverce restored the vercel-new-deployment branch January 4, 2021 20:04
@jverce jverce reopened this Jan 4, 2021
@vercel
Copy link

vercel bot commented Jan 4, 2021

@jverce is attempting to deploy a commit to the Pipedreamers Team on Vercel.

A member of the Team first needs to authorize it.

@jverce jverce removed the request for review from dylburger August 11, 2021 23:48
@jverce jverce assigned jverce and unassigned jverce Aug 11, 2021
@jverce jverce requested review from dylburger and removed request for dylburger August 11, 2021 23:51
@dylburger dylburger self-requested a review September 1, 2021 05:18
@dylburger dylburger removed their request for review September 20, 2021 21:30
@dannyroosevelt dannyroosevelt removed the blocked Issue is blocked pending a resolution label Jan 11, 2022
@jverce
Copy link
Contributor Author

jverce commented Mar 16, 2022

Hey @dannyroosevelt, sorry for the late reply.
The reason why this was blocked was because webhook calls could not be secured as per Vercel's procedure, since the verification process requires access to the OAuth2 client secret that Pipedream uses to connect to Vercel, which is not accessible to the event source.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

2 participants