Update get-weather-data.mjs to fix querying multiple dates

[schluchc]

Dates can be described in multiple ways:
Single date: YYYY-MM-DDTHHZ
Time Period fixed start/end: YYYY-MM-DDTHHZ--YYYY-MM-DDTHHZ:, where is e.g. PT1H for hourly Time Period fixed start/length: YYYY-MM-DDTHHZP:, where is e.g. P3D for three days.

Multiple dates: YYYY-MM-DDTHHZ,YYYY-MM-DDTHHZ,YYYY-MM-DDTHHZ (comma separated. As e.g. Claude tries to join multiple dates with '--' instead of ',' because of that description. This should fix the behavior to query multiple dates

WHY

Summary by CodeRabbit

• Bug Fixes
  • Corrected date/time formatting in weather data requests to use the expected separator, improving compatibility with the weather API.
  • Resolves occasional failures or incomplete results when querying specific date ranges, ensuring accurate and consistent data retrieval.
  • No action required from users; existing parameters, locations, and formats continue to work as before.

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Preview	Comments	Updated (UTC)
pipedream-docs-redirect-do-not-edit	Ignored			Sep 11, 2025 2:06pm

[coderabbitai]

Walkthrough

The Get Weather Data action updates how the validDateTime string is constructed: values are now joined using a comma instead of a double dash. No other parameters, locations, format handling, or exports are changed.

Changes

Cohort / File(s)	Summary of Changes
Get Weather Data action components/meteomatics_weather_api/actions/get-weather-data/get-weather-data.mjs	Updated validDateTime construction to join with "," instead of "--". No changes to parameters, locations, format, or exports.

Sequence Diagram(s)

sequenceDiagram autonumber actor Caller participant Action as GetWeatherDataAction participant API as Meteomatics API Caller->>Action: invoke getWeatherData(params, locations, validDateTimes, format) note right of Action: Build validDateTime by joining with ","<br/>(was "--") Action->>API: HTTP request with parameters, locations, validDateTime, format API-->>Action: Response (data or error) Action-->>Caller: Return parsed result 

Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Pre-merge checks (2 passed, 1 warning)

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description Check	⚠️ Warning	The description documents the date formats and the bug being fixed, but it does not follow the repository's required template because the "## WHY" section is left as the placeholder "", so the mandatory rationale is missing.	Populate the "## WHY" section with a short rationale explaining why the change is needed, its user-facing impact, and any testing or migration notes; include reproduction steps or expected behavior after the fix if possible.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title Check	✅ Passed	The title "Update get-weather-data.mjs to fix querying multiple dates" clearly and concisely identifies the primary change (fixing multiple-date queries) and names the affected file, so a reviewer scanning history can immediately understand the intent and scope of the change.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

Poem

I nibble code like clover leaves,
Swap dashes for commas—light as breeze.
Forecasts hop in tidy lines,
Dates now march in cleaner signs.
Thump-thump! The weather’s set to rhyme,
A carrot-clock for perfect time.

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

• Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
• Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews: pre_merge_checks: custom_checks: - name: "Undocumented Breaking Changes" mode: "warning" instructions: |  Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.

✨ Finishing touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[pipedream-component-development]

Thank you so much for submitting this! We've added it to our backlog to review, and our team has been notified.

[pipedream-component-development]

Thanks for submitting this PR! When we review PRs, we follow the Pipedream component guidelines. If you're not familiar, here's a quick checklist:

• Create components to address specific use cases whenever possible
• Component keys should follow the format app_name_slug-slugified-component-name
• Components should follow the standard directory structure
• Prefer Node.js client libraries to REST APIs
• When making API requests, handle pagination to ensure all data / events are processed
• Use secret props to capture sensitive data
• Props and methods should be defined in app files whenever possible
• Document methods with JS Docs
• Use optional props whenever possible, and set a default value where you can
• Use async options to accept user input wherever possible

[schluchc]

@lcaresia Thanks for writing the MCP!

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

components/meteomatics_weather_api/actions/get-weather-data/get-weather-data.mjs (1)

36-43: Optional: normalize inputs (trim/dedupe) to reduce API 400s from user input

If users paste CSVs with spaces or duplicates, normalize before dispatch.

You could do:

- const validdatetime = Array.isArray(this.validDateTime) - ? this.validDateTime.join(",") - : this.validDateTime; + const toCsv = (v) => + Array.isArray(v) + ? [...new Set(v.map((s) => String(s).trim()))].filter(Boolean).join(",") + : String(v).trim(); + const validdatetime = toCsv(this.validDateTime); + const parameters = toCsv(this.parameters);

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7977501 and a1a694c.

📒 Files selected for processing (1)

• components/meteomatics_weather_api/actions/get-weather-data/get-weather-data.mjs (1 hunks)

🔇 Additional comments (2)

components/meteomatics_weather_api/actions/get-weather-data/get-weather-data.mjs (2)

39-41: Fix is correct: comma-join matches Meteomatics multi-date syntax

Joining validDateTime with "," resolves the multiple-date query bug as described. 👍

---

36-43: Harden for single-string inputs to avoid .join TypeError

Guard when validDateTime/parameters may be single strings — .join throws on strings. Repo search returned no prop definitions; confirm expected types and apply this diff inside run:

 async run({ $ }) { - const response = await this.app.getWeatherData({ + const validdatetime = Array.isArray(this.validDateTime) + ? this.validDateTime.join(",") + : this.validDateTime; + const parameters = Array.isArray(this.parameters) + ? this.parameters.join(",") + : this.parameters; + const response = await this.app.getWeatherData({ $, - validdatetime: this.validDateTime.join(","), - parameters: this.parameters.join(","), + validdatetime, + parameters, locations: this.locations, format: this.format, });