Skip to content

Conversation

jkeenan
Copy link
Contributor

@jkeenan jkeenan commented Oct 6, 2025

Incorporating suggestion from Lukas Mai.

Fixes: GH #23810


  • This set of changes does not require a perldelta entry.
Incorporating suggestion from Lukas Mai. Fixes: GH Perl#23810
Comment on lines +699 to +701
goto FOO;
if (0) {
FOO: print "oops\n";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
goto FOO;
if (0) {
FOO: print "oops\n";
goto GH23810;
if (0) {
GH23810: ;

FOO is too generic for a label, especially in a test file full of labels and gotos. That's why I like to include bug ticket numbers in labels as a source of uniqueness. There already is a FOO: in this file; it is inside a subroutine, so there is no name clash yet, but I want to stay future proof.

Also, if this goto limitation is lifted at some point (technically it is a bug that the if block is optimized away), we don't want to start printing oops randomly, so use a null statement instead.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(technically it is a bug that the if block is optimized away)

Do you know of a ticket number for it?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know of a ticket number for it?

No.

@jkeenan jkeenan self-assigned this Oct 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment