Skip to content

Conversation

@a-kriya
Copy link
Contributor

@a-kriya a-kriya commented May 19, 2017

Also removed both calls to bind:

  • by declaring getCurrentDistance as a method (since it was using this.$el anyway)
  • by moving scrollHandler as a debounced method
@codecov
Copy link

codecov bot commented May 19, 2017

Codecov Report

Merging #51 into master will decrease coverage by 6.66%.
The diff coverage is 84.21%.

Impacted file tree graph

@@ Coverage Diff @@ ## master #51 +/- ## ========================================== - Coverage 100% 93.33% -6.67%  ========================================== Files 1 1 Lines 58 60 +2 Branches 11 11 ========================================== - Hits 58 56 -2  - Misses 0 1 +1  - Partials 0 3 +3
Impacted Files Coverage Δ
src/components/InfiniteLoading.vue 93.33% <84.21%> (-6.67%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ad9578...53cbbfc. Read the comment docs.

@PeachScript
Copy link
Owner

Thank you! But I need some time to think about it, and...the unit test was failed.

Best regards.

@ndelvalle
Copy link

@Syn-zeta Nice work dude, I think the debounce is a good idea.

@PeachScript
Copy link
Owner

Thanks for your attention @ndelvalle @matiastucci , @Syn-zeta has provided a very good idea, I was closed this PR before because the unit tests were not ready for the debounce, and I am doing refactoring now, include the full unit tests and the debounce feature base on @Syn-zeta 's PR :D

@a-kriya
Copy link
Contributor Author

a-kriya commented Aug 23, 2017

That's great. Thank you, @PeachScript.

@PeachScript
Copy link
Owner

You're welcome, thanks for your idea to help this component get better @Syn-zeta

@a-kriya a-kriya deleted the patch-1 branch September 16, 2017 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants