This repository was archived by the owner on Aug 11, 2020. It is now read-only.
Refactor list commands to use share common parent class #89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
kossak reviewed May 10, 2019
paperspace/commands/deployments.py Outdated
| from paperspace.utils import get_terminal_lines | ||
| from paperspace import config, version, client | ||
| from paperspace.commands import common | ||
| from paperspace.commands.common import CommandBase |
There was a problem hiding this comment.
why do you keep importing both common and from common?
There was a problem hiding this comment.
Missed that, fixed now
kossak reviewed May 10, 2019
paperspace/commands/jobs.py Outdated
| from paperspace.commands.common import CommandBase | ||
| from paperspace.utils import get_terminal_lines | ||
| from paperspace.workspace import S3WorkspaceHandler | ||
| from . import common |
There was a problem hiding this comment.
same as above. also, why one time it's relative, other time it's absolute?
… Refactor-list-commands
kossak approved these changes May 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.