This repository was archived by the owner on Aug 11, 2020. It is now read-only.
feat: tell user that we are archiving their local dir PS-10121 #100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
I also fixed the handling of the optional ignore_files argument used in the zip uploader
mkulaczkowski previously requested changes May 15, 2019
| | ||
| @staticmethod | ||
| def _retrieve_file_paths(dir_name, ignored_files=''): | ||
| def _retrieve_file_paths(dir_name, ignored_files=None): |
There was a problem hiding this comment.
This is wrong - if you will keep None you then have to do a check if its not None - this is regression and not a python way - also what is the benefit of doing it like that?
There was a problem hiding this comment.
but this causes a bug - this param is set to None elsewhere and as such comes here. this causes an exception on split attempt
There was a problem hiding this comment.
Yep that's why I changed it. Is there a more pythonic way to approach that? To be clear its set to None by click
kossak reviewed May 16, 2019
| | ||
| exclude = ['.git', '.idea', '.pytest_cache'] | ||
| if ignored_files is not None: | ||
| exclude += ignored_files.split(',') |
There was a problem hiding this comment.
if anything, we could just skip is not None part and simply check if ignored_files:
kossak dismissed mkulaczkowski’s stale review if empty, ignore_files comes as None explicitly
kossak approved these changes May 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
I also fixed the handling of the optional ignore_files argument
used in the zip uploader