Make type of error rate optional. #193
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
xinghai-sun requested changes Aug 9, 2017
| type=str, | ||
| help="There are total two error rate types including wer and cer. wer " | ||
| "represents for word error rate while cer for character error rate. " | ||
| "(default: %(default)s)") |
There was a problem hiding this comment.
Make the wording concise, e.g. Error rate type for evaluation. 'wer' for word error rate and 'cer' for character error rate.
deep_speech_2/evaluate.py Outdated
| num_ins += 1 | ||
| print("WER (%d/?) = %f" % (num_ins, wer_sum / num_ins)) | ||
| print("Final WER (%d/%d) = %f" % (num_ins, num_ins, wer_sum / num_ins)) | ||
| print("%s (%d/?) = %f" % \ |
deep_speech_2/infer.py Outdated
| else: | ||
| error_rate_func = cer | ||
| error_rate_info = 'cer' | ||
| |
There was a problem hiding this comment.
error_rate_func = cer if args.error_rate_type == 'cer' else wer
deep_speech_2/evaluate.py Outdated
| pretrained_model_path=args.model_filepath) | ||
| | ||
| wer_sum, num_ins = 0.0, 0 | ||
| if args.error_rate_type == 'wer': |
There was a problem hiding this comment.
L148-L153 --> error_rate_func = cer if args.error_rate_type == 'cer' else wer
deep_speech_2/evaluate.py Outdated
| num_ins += 1 | ||
| print("WER (%d/?) = %f" % (num_ins, wer_sum / num_ins)) | ||
| print("Final WER (%d/%d) = %f" % (num_ins, num_ins, wer_sum / num_ins)) | ||
| print("%s (%d/?) = %f" % \ |
There was a problem hiding this comment.
Remove error_rate_info and use print("Error rate [%s] ....." % args.error_rate_type) for simplicity ?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.