Adjust sync cycle #328
Merged
Adjust sync cycle #328
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Collaborator Author
| fixes #326 |
Superjomn reviewed Mar 21, 2018
Contributor
Superjomn left a comment
Superjomn left a comment There was a problem hiding this comment.
Logic seems good, but need to follow google c style.
visualdl/logic/im.cc Outdated
| if (data_->parent()->meta.ToSync()) { | ||
| Sync(); | ||
| } | ||
| CHECK(data_); |
Contributor
There was a problem hiding this comment.
The c++ code should follow google c style, indent 2 spaces not 4 spaces.
clang-format can format c++ code automatically.
Collaborator Author
| Updated. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Roughly keep the sync happens every 15~25 seconds.