Skip to content

Conversation

@nickyfantasy
Copy link
Contributor

No description provided.

varunarora
varunarora previously approved these changes Feb 9, 2018
Copy link

@varunarora varunarora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very clear and straightforward and to-the-point documentation. Great stuff!

Any code changes in ```server``` folder, simply run

```
python visualdl/server/visualDL --logdir={LOG_DIR} --port=8080

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I had a problem on this step wherein it was importing libraries from the pip installed version of visualDL. So I had to resolve it by resetting my PYTHONPATH. You don't need to explain it as much as it would be nice if it is mentioned in a comment.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ya, I run into same issue, let me update


#### Information Container
- Currently it just handles logic of sync cycle (when to write)
- In future we may add logic of when to read
Copy link
Contributor

@Superjomn Superjomn Feb 9, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When to read needn't be synced or controlled, because the R/W conflicts happen rarely, and the web service can be retriggered a few times, that is a cheap but relatively not bad way to assure read service reliability.

The read service should not affect the writing service, that is the key.

- ```Record``` : represent any data structure for any component
- Handles the actual logic to serialized to disk and deserialized from disk
- ```storage.proto```: protobuf file that defines the exact interface to be read/write

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove the empty line in the tail.

Copy link
Collaborator

@jetfuel jetfuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff. Thanks

@nickyfantasy nickyfantasy merged commit 711c9bf into PaddlePaddle:develop Feb 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants