VDL slow when user sets incorrect log directory #249
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…all fails the first time. The issue is the method lib.retry will sleep the thread for 2 seconds after an exception. Since VDL was not running in threaded mode, this causes all request to the server to stop immediately, therefore even requests to get static resource are frozen. This change enables threaded mode in flask.
| LGTM |
nickyfantasy approved these changes Feb 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This fix resolves #243
VDL is set to retry an pybinded API call multiple times in case the call fails the first time. The issue is the method lib.retry will sleep the thread for 2 seconds after an exception. Since VDL was not running in threaded mode, this causes all request to the server to stop immediately, therefore even requests to get static resource are frozen. This change enables threaded mode in flask.