Cpp python style check #215
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Collaborator
cs2be commented Jan 26, 2018
cs2be commented - Add flake8 pre-commit hook (this will check python file for PEP8) compliance. Use "pip install flake8" to install locally
- Execute pre-commit during travis-ci checkin
- Update code to conform to coding standards
…that violate coding standards.
…that violate coding standards.
cs2be requested review from Superjomn, daming-lu, jacquesqiao, jetfuel and nickyfantasy 
| @cs2be Need to update the branch |
Superjomn previously requested changes Jan 26, 2018
visualdl/storage/storage.h Outdated
| #include <algorithm> | ||
| #include <set> | ||
| #include <vector> | ||
| #include "visualdl/utils/logging.h" |
There was a problem hiding this comment.
this line should be moved to line22, together with other "".
same with other occasions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.