Skip to content

Conversation

@DesmonDay
Copy link
Contributor

Before submitting

  • Lint code. If there are lint issues, please format the code first.
# Install and register `pre-commit` in the project folder pip install pre-commit && pre-commit install # Process previous code files separately pre-commit run --file XXXX.py
  • Add test cases into tests folder. If there are codecov issues, please add tests cases first.

PR types

Bug fixes

PR changes

Others

Description

同时开启ignore_merge_optimizer和split_param模式下,直接加载保存下来的checkpoint会报错,此处进行修复。

@paddle-bot
Copy link

paddle-bot bot commented Feb 24, 2025

Thanks for your contribution!

@codecov
Copy link

codecov bot commented Feb 24, 2025

Codecov Report

Attention: Patch coverage is 6.50407% with 115 lines in your changes missing coverage. Please review.

Project coverage is 51.31%. Comparing base (30df8b6) to head (99fb78d).
Report is 343 commits behind head on develop.

Files with missing lines Patch % Lines
...r/unified_checkpoint/sharding_split_param_utils.py 5.83% 113 Missing ⚠️
...p/trainer/unified_checkpoint/unified_checkpoint.py 33.33% 2 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@ ## develop #9935 +/- ## =========================================== - Coverage 51.34% 51.31% -0.03%  =========================================== Files 745 745 Lines 118590 118678 +88 =========================================== + Hits 60886 60902 +16  - Misses 57704 57776 +72 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
@ZHUI ZHUI force-pushed the fix_split_param_v2 branch from f578946 to c0c7c78 Compare February 24, 2025 11:30
@ZHUI ZHUI force-pushed the fix_split_param_v2 branch from c0c7c78 to 1e250f4 Compare February 24, 2025 11:53
@ZHUI ZHUI force-pushed the fix_split_param_v2 branch from 52fbbf3 to 99fb78d Compare February 24, 2025 12:15
Copy link
Contributor

@ZHUI ZHUI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZHUI ZHUI merged commit 011ae71 into develop Feb 26, 2025
11 of 14 checks passed
@ZHUI ZHUI deleted the fix_split_param_v2 branch February 26, 2025 08:02
ZHUI pushed a commit that referenced this pull request Feb 27, 2025
…re_merge_optimizer (#9935) * fix * refine code * update typename
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants