Skip to content

Fix multi-threading load_state_dict #9464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
wawltor merged 3 commits into from
Dec 3, 2024
Merged

Fix multi-threading load_state_dict #9464

wawltor merged 3 commits into from
Dec 3, 2024

Conversation

@DesmonDay
Copy link
Contributor

@DesmonDay DesmonDay commented Nov 20, 2024 •
edited
Loading

PR types

Others

PR changes

Others

Description

  1. Add logger for loading state_dict number.
  2. Fix state_dict update.
@paddle-bot
Copy link

paddle-bot bot commented Nov 20, 2024

Thanks for your contribution!
wawltor
wawltor previously approved these changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@wawltor wawltor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@codecov
Copy link

codecov bot commented Nov 20, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 33.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 53.04%. Comparing base (2c1387f) to head (3c6b969).
Report is 211 commits behind head on develop.

Files with missing lines Patch % Lines
paddlenlp/transformers/model_utils.py 33.33% 4 Missing ⚠️
Additional details and impacted files 
@@ Coverage Diff @@ ## develop #9464 +/- ## =========================================== + Coverage 52.85% 53.04% +0.19%  =========================================== Files 700 701 +1 Lines 110418 110636 +218 =========================================== + Hits 58359 58687 +328  + Misses 52059 51949 -110

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.
@DesmonDay DesmonDay changed the title Update model_utils.py Fix multi-threading load_state_dict Dec 3, 2024
wawltor
wawltor approved these changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@wawltor wawltor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@wawltor wawltor merged commit c4d79f4 into develop Dec 3, 2024
10 of 14 checks passed
@ZHUI ZHUI deleted the DesmonDay-patch-3 branch December 3, 2024 08:25
DesmonDay added a commit to DesmonDay/PaddleNLP that referenced this pull request Dec 3, 2024
@DesmonDay
Fix multi-threading load_state_dict (PaddlePaddle#9464)
1101086 
* Update model_utils.py * Update model_utils.py
DesmonDay added a commit that referenced this pull request Dec 3, 2024
@DesmonDay
[Cherry-pick] fix multi-threading load, fix single card load. (#9560)
feea4c3 
* Fix multi-threading load_state_dict (#9464) * Update model_utils.py * Update model_utils.py * [Unified Checkpoint] fix single card loading without master weights (#9540)
DesmonDay added a commit that referenced this pull request Dec 13, 2024
@DesmonDay
[Trainer] Add embedding trainer (#9625)
b0900de 
* Fix multi-threading load_state_dict (#9464) * Update model_utils.py * Update model_utils.py * [Unified Checkpoint] fix single card loading without master weights (#9540) * update embedding trainer (#9608)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@DesmonDay @wawltor