add flashmask rm #9154
Merged
add flashmask rm #9154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
|
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@ ## develop #9154 +/- ## =========================================== - Coverage 53.06% 53.02% -0.05% =========================================== Files 656 656 Lines 106147 106162 +15 =========================================== - Hits 56324 56288 -36 - Misses 49823 49874 +51 ☔ View full report in Codecov by Sentry. |
gongel reviewed Sep 25, 2024
| rejected_indexes = paddle.to_tensor( | ||
| [[response_index[0], response_index[2]] for response_index in response_indexs] | ||
| ) | ||
| chosen_hidden_states = hidden_states.gather_nd(chosen_indexes) |
| """main""" | ||
| parser = PdArgumentParser((ModelArgument, DataArgument, TrainingArguments)) | ||
| if len(sys.argv) == 2 and sys.argv[1].endswith(".json"): | ||
| model_args, data_args, training_args = parser.parse_json_file(json_file=os.path.abspath(sys.argv[1])) |
Member
There was a problem hiding this comment.
这里要不支持下json和命令行，因为ce里面可能会增加命令行去覆盖json的配置，可参考这里：https://github.com/PaddlePaddle/PaddleNLP/blob/develop/llm/run_finetune.py#L77
| logger.info("Start to create dataset") | ||
| trans_func = partial(preprocess_preference_data, tokenizer=tokenizer, data_args=data_args, model_args=model_args) | ||
| if data_args.lazy: | ||
| zero_padding_dataset = ZeroPaddingIterableDataset |
gongel approved these changes Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
Others
Description
rm