Skip to content

[LLM] fix train on npu #9101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
wawltor merged 2 commits into from
Sep 6, 2024
Merged

[LLM] fix train on npu #9101

wawltor merged 2 commits into from
Sep 6, 2024

Conversation

@SylarTiaNII
Copy link
Contributor

@SylarTiaNII SylarTiaNII commented Sep 6, 2024 •
edited
Loading

PR types

Bug fixes

PR changes

Others

Description

fix train on npu since comm using bool is not supported in HCCL
@paddle-bot
Copy link

paddle-bot bot commented Sep 6, 2024

Thanks for your contribution!
wawltor
wawltor approved these changes Sep 6, 2024
View reviewed changes
Copy link
Contributor

@wawltor wawltor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@wawltor wawltor merged commit d245d07 into PaddlePaddle:develop Sep 6, 2024
@codecov
Copy link

codecov bot commented Sep 7, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 53.47%. Comparing base (c90dc87) to head (cd1670c).
Report is 217 commits behind head on develop.

Files with missing lines Patch % Lines
paddlenlp/trainer/trainer.py 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@ Coverage Diff @@ ## develop #9101 +/- ## =========================================== + Coverage 53.34% 53.47% +0.13%  =========================================== Files 652 652 Lines 105401 105401 =========================================== + Hits 56222 56367 +145  + Misses 49179 49034 -145

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.
ckl117 pushed a commit to ckl117/PaddleNLP that referenced this pull request Sep 9, 2024
@SylarTiaNII @ckl117
[LLM] fix trainer on npu (PaddlePaddle#9101)
00d2585
SylarTiaNII added a commit to SylarTiaNII/PaddleNLP that referenced this pull request Sep 9, 2024
@SylarTiaNII
[LLM] fix trainer on npu (PaddlePaddle#9101)
513fc82
JunnYu pushed a commit that referenced this pull request Sep 9, 2024
@SylarTiaNII
[LLM] fix trainer on npu (#9101) (#9111)
abc28d9
Mangodadada pushed a commit to Mangodadada/PaddleNLP that referenced this pull request Sep 10, 2024
@SylarTiaNII @Mangodadada
[LLM] fix trainer on npu (PaddlePaddle#9101)
f469015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@SylarTiaNII @wawltor