Skip to content

Conversation

@sneaxiy
Copy link
Collaborator

@sneaxiy sneaxiy commented Aug 28, 2024

PR types

Others

PR changes

Others

Description

Add is_distributed field in sharding reshard param_meta. Cherry-pick #8875 .

@paddle-bot
Copy link

paddle-bot bot commented Aug 28, 2024

Thanks for your contribution!

@codecov
Copy link

codecov bot commented Aug 28, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 53.87%. Comparing base (154928a) to head (450e706).
Report is 235 commits behind head on develop.

Files with missing lines Patch % Lines
paddlenlp/trainer/utils/sharding_io.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@ ## develop #9028 +/- ## =========================================== - Coverage 54.06% 53.87% -0.19%  =========================================== Files 650 652 +2 Lines 103883 104357 +474 =========================================== + Hits 56164 56222 +58  - Misses 47719 48135 +416 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@wawltor wawltor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wawltor wawltor merged commit c656452 into PaddlePaddle:develop Aug 28, 2024
@sneaxiy sneaxiy deleted the cherry_pick_is_distributed branch August 28, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants