[Tokenizer] Support for loading added_tokens_decoder #8997
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Thanks for your contribution! |
DrownFish19 changed the title …x_added_tokens_decoder_load
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@ ## develop #8997 +/- ## =========================================== - Coverage 54.51% 53.89% -0.63% =========================================== Files 648 652 +4 Lines 103473 104388 +915 =========================================== - Hits 56406 56255 -151 - Misses 47067 48133 +1066 ☔ View full report in Codecov by Sentry. |
DrownFish19 commented Aug 28, 2024
| """ | ||
| return len(self.encoder) | ||
| | ||
| def __len__(self): |
Collaborator Author
There was a problem hiding this comment.
mamba tokenizer的added_tokens_decoder中包含 [0,1]两个重复tokens，之前的计算方式会重复计算这两个token
DrownFish19 commented Aug 28, 2024
| """Returns vocab size""" | ||
| return self.sp_model.get_piece_size() | ||
| | ||
| def __len__(self): |
Collaborator Author
There was a problem hiding this comment.
解决无法添加token的问题
DrownFish19 commented Aug 28, 2024
| """Returns vocab size""" | ||
| return self.sp_model.get_piece_size() | ||
| | ||
| def __len__(self): |
Collaborator Author
There was a problem hiding this comment.
解决无法添加token的问题
DrownFish19 changed the title DrownFish19 changed the title 
ZHUI approved these changes Aug 28, 2024
Mangodadada pushed a commit to Mangodadada/PaddleNLP that referenced this pull request Sep 10, 2024
* fix added_tokens_decoder load * fix decode * fix saving and loading added_token_decoder * fix mamba * fix special_tokens_map_file load * fix gemma tokenizer * fix llama tokenzier * revert llama tokenizer * fix _decode
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
PR types
Bug fixes
PR changes
Others
Description
The new tokenizer_config.json now includes the added_tokens_decoder, and we load them in the PretrainedTokenizer _pre_init.