Skip to content

Conversation

@ZHUI
Copy link
Contributor

@ZHUI ZHUI commented Jun 5, 2024

PR types

Others

PR changes

Others

Description

Others

@paddle-bot
Copy link

paddle-bot bot commented Jun 5, 2024

Thanks for your contribution!

@codecov
Copy link

codecov bot commented Jun 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.96%. Comparing base (79e8b6e) to head (5d34b49).
Report is 243 commits behind head on develop.

Additional details and impacted files
@@ Coverage Diff @@ ## develop #8549 +/- ## =========================================== + Coverage 53.86% 54.96% +1.10%  =========================================== Files 620 620 Lines 97090 97109 +19 =========================================== + Hits 52298 53377 +1079  + Misses 44792 43732 -1060 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

in_sep_parallel_mode = self.args.sep_parallel_degree > 1
in_cp_parallel_mode = self.args.context_parallel_degree > 1

# Multi-gpu training
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个地方需要合入到2.8吗?

Copy link
Contributor

@DesmonDay DesmonDay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZHUI ZHUI merged commit f89c91d into PaddlePaddle:develop Jun 7, 2024
@ZHUI ZHUI deleted the fix/ddp branch June 7, 2024 06:53
ZHUI added a commit to ZHUI/PaddleNLP that referenced this pull request Jun 7, 2024
* enable trainer tests.
DesmonDay pushed a commit that referenced this pull request Jun 7, 2024
* [Safetensors] Fix fast safe open slice. (#8512) * [FIX DDP] fix ddp (#8549)
DesmonDay pushed a commit to DesmonDay/PaddleNLP that referenced this pull request Sep 5, 2024
* [Safetensors] Fix fast safe open slice. (PaddlePaddle#8512) * [FIX DDP] fix ddp (PaddlePaddle#8549)
DesmonDay added a commit that referenced this pull request Sep 5, 2024
* quick fix from pretrained. (#8487) * quick fix os.path.split (#8508) * Cp/fix (#8569) * [Safetensors] Fix fast safe open slice. (#8512) * [FIX DDP] fix ddp (#8549) * [BUG] Fix build train valid test datasets (#8823) * Update causal_dataset.py * Add twenty redundant data in post pretrain (#8777) * 给dataset再添加20条数据,防止blend dataset出现错误 * num_samples向下去整,防止数据集的溢出 (#8691) * update release_grads (#8834) * update release_grads (#8834) * [Trainer] Fix release_grads (#9085) * fix pp release_grads * add dataloader_drop_last to evaldataloader (#8773) * bugfix * Fix eval hang (#9052) * fix pipeline eval * fix eval dataloader_num_workers --------- Co-authored-by: Zhong Hui <zhonghui.net@gmail.com> Co-authored-by: yujun <50394665+JunnYu@users.noreply.github.com> Co-authored-by: gongel <ainlp88@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants