Skip to content

Conversation

@sneaxiy
Copy link
Collaborator

@sneaxiy sneaxiy commented Mar 19, 2024

PR types

Bug fixes

PR changes

Others

Description

Cherry-pick #8141 .

@paddle-bot
Copy link

paddle-bot bot commented Mar 19, 2024

Thanks for your contribution!

Copy link
Contributor

@ZHUI ZHUI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Mar 19, 2024

Codecov Report

Attention: Patch coverage is 9.09091% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 55.38%. Comparing base (5779186) to head (87e5ee0).
Report is 3 commits behind head on develop.

Files Patch % Lines
paddlenlp/trainer/training_args.py 9.09% 10 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@ ## develop #8146 +/- ## =========================================== - Coverage 56.45% 55.38% -1.07%  =========================================== Files 596 596 Lines 91602 91605 +3 =========================================== - Hits 51711 50733 -978  - Misses 39891 40872 +981 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wawltor wawltor merged commit f658fa7 into PaddlePaddle:develop Apr 16, 2024
@sneaxiy sneaxiy deleted the fix_sharding_100_limit_dev branch April 17, 2024 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants