Download----fix new bug #8088
Merged
Download----fix new bug #8088
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Thanks for your contribution! |
JunnYu reviewed Mar 11, 2024
paddlenlp/utils/download/__init__.py Outdated
| if cache_file_name is not None and not isinstance(cache_file_name, object): | ||
| return cache_file_name | ||
| if cache_file_name is not None: | ||
| if ((from_aistudio or from_hf_hub) and not isinstance(cache_file_name, object)) or from_bos: |
Member
There was a problem hiding this comment.
if from_hf_hub and cache_file_name is _CACHED_NO_EXIST: cache_file_name = None if cache_file_name is not None: xxxxxxxxxxx
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@ ## develop #8088 +/- ## =========================================== - Coverage 56.46% 56.46% -0.01% =========================================== Files 596 596 Lines 91564 91576 +12 =========================================== + Hits 51704 51708 +4 - Misses 39860 39868 +8 ☔ View full report in Codecov by Sentry. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
PR types
Bug fixes
PR changes
修改模型默认下载优先级、修复cache加载文件时的bug、增加对下载文件是否为None的检查
Description
修复新的Download逻辑中测试所发现的新bug