Skip to content

Conversation

@FeixLiu
Copy link
Contributor

@FeixLiu FeixLiu commented Jan 24, 2024

PR types

Others

PR changes

Others

Description

gqa fuse attention qkv

7B model, non_fuse vs fuse

a37aef3086e4c8df8d4de4640ab034f9

3.5B model, 4mp vs 8mp

image
@paddle-bot
Copy link

paddle-bot bot commented Jan 24, 2024

Thanks for your contribution!

@codecov
Copy link

codecov bot commented Jan 24, 2024

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (44bfeb0) 56.80% compared to head (5026243) 56.57%.
Report is 1 commits behind head on develop.

Files Patch % Lines
paddlenlp/transformers/llama/modeling.py 22.22% 7 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@ ## develop #7890 +/- ## =========================================== - Coverage 56.80% 56.57% -0.23%  =========================================== Files 588 589 +1 Lines 89536 91330 +1794 =========================================== + Hits 50858 51674 +816  - Misses 38678 39656 +978 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@FeixLiu FeixLiu force-pushed the support_gqa_fusion branch from 7b04017 to 896c01f Compare January 29, 2024 23:15
@FeixLiu FeixLiu force-pushed the support_gqa_fusion branch from c79b7e2 to 5026243 Compare January 31, 2024 09:10
Copy link
Contributor

@ZHUI ZHUI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FeixLiu FeixLiu closed this Jan 31, 2024
@FeixLiu FeixLiu reopened this Jan 31, 2024
@wawltor wawltor merged commit c0c64fa into PaddlePaddle:develop Feb 1, 2024
@FeixLiu FeixLiu deleted the support_gqa_fusion branch February 1, 2024 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants