Skip to content

Conversation

@liuzhenhai93
Copy link
Contributor

@liuzhenhai93 liuzhenhai93 commented Jan 11, 2024

PR types

Others

PR changes

Others

Description

@paddle-bot
Copy link

paddle-bot bot commented Jan 11, 2024

Thanks for your contribution!

@codecov
Copy link

codecov bot commented Jan 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4069f22) 56.95% compared to head (b7f9f2d) 56.95%.

Additional details and impacted files
@@ Coverage Diff @@ ## develop #7830 +/- ## ======================================== Coverage 56.95% 56.95% ======================================== Files 587 587 Lines 88628 88628 ======================================== Hits 50480 50480 Misses 38148 38148 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ZHUI ZHUI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@sneaxiy sneaxiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the rms_norm operator in the main PaddlePaddle repo. @liuzhenhai93

@sneaxiy sneaxiy merged commit f039d09 into PaddlePaddle:develop Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants