Skip to content

Conversation

@DrownFish19
Copy link
Collaborator

PR types

Bug fixes

PR changes

Others

Description

  1. save master weights name as model weights name when SKIP_SAVE_MODEL_WEIGHT.
  2. fix config save skip when SKIP_SAVE_MODEL_WEIGHT.
change master weigths name to model weigths name when SKIP_SAVE_MODEL_WEIGHT
when skipping model weighs save and saving master weights as model weights, unified checkpoint needs choose the model weights to load into master weights.
To test file list and file name when skip_save_model_weight=1
@paddle-bot
Copy link

paddle-bot bot commented Jan 8, 2024

Thanks for your contribution!

@codecov
Copy link

codecov bot commented Jan 9, 2024

Codecov Report

Attention: 33 lines in your changes are missing coverage. Please review.

Comparison is base (cf907fc) 56.91% compared to head (1ba0a12) 56.90%.

Files Patch % Lines
paddlenlp/trainer/plugins/unified_checkpoint.py 3.03% 32 Missing ⚠️
paddlenlp/trainer/training_args.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@ ## develop #7795 +/- ## =========================================== - Coverage 56.91% 56.90% -0.01%  =========================================== Files 587 587 Lines 88724 88740 +16 =========================================== + Hits 50496 50498 +2  - Misses 38228 38242 +14 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DrownFish19 DrownFish19 force-pushed the dev_unified_checkpoint branch from 2fa914a to 6becb65 Compare January 16, 2024 01:13
@wawltor wawltor merged commit 48c1313 into PaddlePaddle:develop Jan 17, 2024
@DrownFish19 DrownFish19 deleted the dev_unified_checkpoint branch January 17, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants