refine sync_with_cpp when remove ops or remove vars #9600
Merged
+37 −4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
typhoonzero approved these changes Apr 3, 2018
| def test_remove_op(self): | ||
| prog = core.ProgramDesc() | ||
| program = Program() | ||
| prog = program.desc |
There was a problem hiding this comment.
prog_desc can be more clear.
There was a problem hiding this comment.
Ok, I will update it in next PR.
This was referenced Apr 3, 2018
typhoonzero pushed a commit to typhoonzero/Paddle that referenced this pull request Apr 4, 2018
refine sync_with_cpp when remove ops or remove vars
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Currently,
sync_with_cpponly deals with adding ops or adding variables from c++ end. Thus, if we callblock.remove_opfirst, and then callblock.sync_with_cpp, there exist errors.This PR refines
sync_with_cppwhen removing ops or remove variables from c++ end, and test thesync_with_cppfunction in the unit test.