Expose RMSProp optimizer. #9247
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
pkuyym reviewed Mar 20, 2018
python/paddle/fluid/optimizer.py Outdated
| class RMSPropOptimizer(Optimizer): | ||
| """ | ||
| Root Mean Squared Propagation (RMSProp) is an unpublished, adaptive learning | ||
| rate method. The original slides that proposed Rmsprop: Slide 29 of |
Contributor
There was a problem hiding this comment.
slides that proposed Rmsprop --> slides proposed Rmsprop
python/paddle/fluid/optimizer.py Outdated
| .. math:: | ||
| r(w, t) & = \\rho r(w, t-1) + (1 - \\rho)(\\nabla Q_{i}(w))^2 \\\\ | ||
| v(w, t) & = \\beta v(w, t-1) + \\frac{\\eta} {\\sqrt{v(w,t) + \\epsilon}} \\nabla Q_{i}(w) |
python/paddle/fluid/optimizer.py Outdated
| learning_rate(float): global leraning rate. | ||
| rho(float): rho is :math: `\\rho` in equation, set 0.95 by default. | ||
| epsilon(float): :math: `\\epsilon` in equation is smoothing term to | ||
| avoids division by zero, set 1e-6 by default. |
| set 0.0 by default. | ||
| Examples: |
Contributor
There was a problem hiding this comment.
Add a new section Raises is better.
python/paddle/fluid/optimizer.py Outdated
| self._momentum = momentum | ||
| | ||
| def _create_accumulators(self, block, parameters): | ||
| assert isinstance(block, framework.Block) |
Contributor
There was a problem hiding this comment.
这里是不是也需要改成raise，以免assert在非debug模式下失效？
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fix #9246