Update conll05.py #8495
Merged
Update conll05.py #8495
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
the label file in the conll05 dataset has a wrong order
|
|
wangkuiyi reviewed Feb 22, 2018
There was a problem hiding this comment.
Thank you for this PR! It seems that it is fixing a bug -- the format of label file differs from that of the vocabulary file. Do you mind adding an issue describing this bug, and mark this PR as fixing this issue by writing "Fix #xxx" in the description of this PR? (#xxx is the id of the issue you just created.) . Thanks!
python/paddle/v2/dataset/conll05.py Outdated
| tag_dict.add(line[2:]) | ||
| elif line.startswith("I-"): | ||
| tag_dict.add(line[2:]) | ||
| else: |
There was a problem hiding this comment.
I am not a Python expert, but it seems that we can remove L54-L55?
Fix #8079 and remove the redundant code
| I mentioned this problem in issue #8079 before, and it is now marked in description. And in the new update, the redundant two lines of code are deleted. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
the label file in the conll05 dataset has a wrong order. The pull request let the label dict in right order. Fix #8079 。