Added an elementary unit test for CSP #8340
Merged
+37 −0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
wangkuiyi reviewed Feb 10, 2018
| | ||
| | ||
| class TestCSPFramework(unittest.TestCase): | ||
| def helper(self, left, right): |
There was a problem hiding this comment.
This function has only one line; why make it a function?
There was a problem hiding this comment.
I see. I am sure that here we should not need to define the helper function.
There was a problem hiding this comment.
Fixed in latest commit
| import paddle.v2.fluid as fluid | ||
| | ||
| | ||
| class TestCSPFramework(unittest.TestCase): |
There was a problem hiding this comment.
Could we make sure that this unit test doesn't break the CI before we finish the implementation of CSP?
There was a problem hiding this comment.
@wangkuiyi I made sure that this PR doesn't break the CI. Both TeamCity and Travis pass.
wangkuiyi approved these changes Feb 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
@abhinavarora and I designed this unit test for the proposed imperative programming paradigm in https://github.com/PaddlePaddle/Paddle/blob/develop/doc/design/csp.md .
This is a unit test that implements the Daisy Chain as explained here: https://talks.golang.org/2012/concurrency.slide#39 using the concepts of concurrent programming in Fluid.
Fix #8338