Skip to content

Refine Channel's unit test #8222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 9, 2018
Merged

Refine Channel's unit test #8222

merged 5 commits into from
Feb 9, 2018

Conversation

@chengduoZH
Copy link
Contributor

@chengduoZH chengduoZH commented Feb 7, 2018 •
edited
Loading

To simplify the code,

  • the function UnbufferedChannelCloseUnblocksSendersTest and the function BufferedChannelCloseUnblocksSendersTest use a common function(ChannelCloseUnblocksSendersTest).
  • the function UnbufferedChannelCloseUnblocksReceiversTest and the function BufferedChannelCloseUnblocksReceiversTest use a common function(ChannelCloseUnblocksReceiversTest)

To get someone else to understand channel faster, I add the properties of BufferedChannel and UnBufferedChannel in buffered_channel.h and unbuffered_channel.h.
abhinavarora
abhinavarora approved these changes Feb 7, 2018
View reviewed changes
Copy link
Contributor

@abhinavarora abhinavarora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great work!
@chengduoZH chengduoZH merged commit 6b49401 into PaddlePaddle:develop Feb 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@chengduoZH @abhinavarora