Simplify the inference unittests' cmake and codes. #8216
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
luotao1 reviewed Feb 8, 2018
| DEPS ARCHIVE_START paddle_fluid ARCHIVE_END | ||
| ARGS --dirname=${PYTHON_TESTS_DIR}/book/${TARGET_NAME}.inference.model) | ||
| set_tests_properties(test_inference_${TARGET_NAME} | ||
| PROPERTIES DEPENDS test_${TARGET_NAME}) |
There was a problem hiding this comment.
想象一下，如果避免重复，逻辑可以变成下面这样：
if(inference_test_ARGS) 每个arg前面加一个"__" else() 新增一个arg："_" endif() foreach(arg ${inference_test_ARGS}) arg去掉最前面的"_" cc_test(...) set_tests_properties(...) endforeach() There was a problem hiding this comment.
可以的，为了避免加其他单测时这里的冲突，简化可以放到下一个PR来完成。
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fix #8229