Test case to check if receiver blocks on empty channel, and resumes on close. #8166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
6 tasks
wangkuiyi reviewed Feb 6, 2018
| // Read from channel | ||
| int out; | ||
| ch->Receive(&out); // should block since channel is empty | ||
| current = 10; |
There was a problem hiding this comment.
Thank you for the review.
I just realized that we already checked in the test cases : BufferedChannelCloseUnblocksReceiversTest and UnbufferedChannelCloseUnblocksReceiversTest that perform these operations already.
In that case, this PR would be redundant and maybe I can close it.
| } | ||
| | ||
| void ReceiveEmptyChannelTest(Channel* ch) { | ||
| size_t current = 5; |
| void ReceiveEmptyChannelTest(Channel* ch) { | ||
| size_t current = 5; | ||
| std::thread t([&]() { | ||
| // Read from channel |
| delete ch; | ||
| } | ||
| | ||
| void ReceiveEmptyChannelTest(Channel* ch) { |
There was a problem hiding this comment.
The prefix Test is a convention of unit test names. This function is not a unit test; a better name could be ReceiveFromEmptyChannelShouldBlock.
| A rewrite is as follows: void ReceiveFromEmptyChannelShouldBlockAndCloseUnblocksIt(Channel *ch) { bool received = false; std::thread t([&]() { int out; ch->Receive(&out); // should block since channel is empty received = true; }); std::this_thread::sleep_for(std::chrono::milliseconds(100)); // wait 0.1 sec EXPECT_EQ(received, false); // the receiver should be blocked since channel is empty CloseChannel(ch); t.join(); EXPECT_EQ(received, true); // when we close the channel, the receiver should unblock delete ch; } TEST(Channel, ReceiveFromEmptyBufferedChannelShouldBlockAndCloseUnblocksIt) { auto ch = MakeChannel<size_t>(3); // buffered ReceiveFromEmptyChannelShouldBlockAndCloseUnblocksIt(ch); } TEST(Channel, ReceiveFromEmptyUnBufferedChannelShouldBlockAndCloseUnblocksIt) { auto ch = MakeChannel<size_t>(0); // unbuffered ReceiveEmptyChannelTest(ch); } |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.