Fixing unbuffered test to a generic test #8162
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
wangkuiyi reviewed Feb 5, 2018
paddle/framework/channel_test.cc Outdated
| // This test tests that send and receive operations are ordered, | ||
| // as in , the sequence in which objects were sent will be the same | ||
| // as the sequence in which they were received. | ||
| TEST(Channel, OrderedSendReceiveChannelTest) { |
There was a problem hiding this comment.
OrderedSendReceiveChannelTest => RecevingOrderEqualToSendingOrder
… unit_test_channel
… unit_test_channel
added 3 commits February 7, 2018 15:14
… unit_test_channel
… unit_test_channel
… unit_test_channel
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue : #8160 by implementing proposal #1.