Change the 'mul_op' to 'matmul_op' in fc. #8101
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| 为什么需要这个修改，能否在issue里面说明一下？相关的issue没有描述。 |
peterzhang2029 force-pushed the mul_fix branch from 75e5366 to 0601515 Compare 
dzhwinter reviewed Feb 7, 2018
| Thus, the flattened matrix will have a shape [2 x 3 x 4, 5 x 6] = | ||
| [24, 30]. The default value 0 indicates the input is a 2-D Matrix. | ||
| )DOC") | ||
| .SetDefault(0) |
There was a problem hiding this comment.
double check the default value, Please.
| mul_op 和 matmul_op 是两种计算。这个PR如果是为了将两者统一，最好再仔细确认一下计算逻辑。这两个op不能简单的删掉一个。 |
| 感谢您给PaddlePaddle贡献代码。由于Paddle V1/V2版本已不再维护，相关代码也已从develop分支上删除，因此关闭您的PR，欢迎您向Paddle最新版-Fluid贡献代码。 |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
resolve #8100