Proposing Python syntax for send and recv in design doc #8093
Conversation
kavyasrinet requested review from abhinavarora, chengduoZH, helinwang and wangkuiyi 
doc/design/csp.md Outdated
| ch = fluid.make_channel(dtype=INT) | ||
| | ||
| # Writes and Reads are synchronous otherwise the calls will block. | ||
| ch.send(10) |
There was a problem hiding this comment.
I think this line will block forever, since no one is reading from another thread.
There was a problem hiding this comment.
You are right, I completely forgot to write threads for that. Just pushed it in a commit.
| | ||
| def send_to_channel(channel, num_time=1): | ||
| for i in xrange(num_time): | ||
| channel.send(i) |
There was a problem hiding this comment.
- The send operation must be a global function, but not the method of buffer, because it must be able to handle the case that the buffer is nil.
- The send operation has to be a fluid operator, not a Python function or method.
| ch = fluid.make_channel(dtype=INT, buffer_size) | ||
| | ||
| # Now write three elements to the channel | ||
| thread = threading.Thread(target=send_to_channel, args=(ch, 3, )) |
There was a problem hiding this comment.
To check it works, we need fluid.go, instead of threading.
| | ||
| # Read all the data from the channel | ||
| for i in xrange(3): | ||
| y = ch.recv() |
There was a problem hiding this comment.
y = fluid.recv(ch)
It doesn't help at all to expose the C++ method Channel::Recv to Python as Channel::recv.
| y = ch.recv() | ||
| | ||
| # Done receiving , now close the channel | ||
| ch.close() |
| ch = fluid.make_channel(dtype=INT, buffer_size) | ||
| | ||
| # Now write three elements to the channel | ||
| thread = threading.Thread(target=send_to_channel, args=(ch, 3, )) |
There was a problem hiding this comment.
To illustrate how to use buffered channels, we don't need the goroutine, because the purpose is to show that the single thread example wouldn't block as long as the buffer size is big enough.
3 participants
In addition to the PR: #7908 that covers the syntax for
Select, this PR covers proposed Python syntax forSend/Recvoperations.