- Notifications
You must be signed in to change notification settings - Fork 5.9k
memory optimization for dynamic RNN #8041
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits Select commit Hold shift + click to select a range
6de62d5 init
QiJune bc801ad add delete operator
QiJune 8ec6ebb debug
QiJune 52d5f50 add wait
QiJune f123cc0 clean code
QiJune e8d9098 fix bug
QiJune 48ec945 fix bug
QiJune 85f812a refine code
QiJune 49b768f remove unused code
QiJune File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| | @@ -99,6 +99,9 @@ class WhileGradOp : public framework::OperatorBase { | |
| | ||
| void Run(const framework::Scope &scope, | ||
| const platform::Place &dev_place) const override { | ||
| // get device context from pool | ||
| platform::DeviceContextPool &pool = platform::DeviceContextPool::Instance(); | ||
| auto &dev_ctx = *pool.Get(dev_place); | ||
| framework::Executor executor(dev_place); | ||
| auto *block = Attr<framework::BlockDesc *>(kStepBlock); | ||
| auto *program = block->Program(); | ||
| | @@ -205,6 +208,8 @@ class WhileGradOp : public framework::OperatorBase { | |
| sum_op->Run(cur_scope, dev_place); | ||
| cur_scope.Rename(new_inside_name, inside_grad_name); | ||
| } | ||
| dev_ctx.Wait(); | ||
| const_cast<framework::Scope &>(scope).DeleteScope(&cur_scope); | ||
| There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nice catch! | ||
| } | ||
| } | ||
| }; | ||
| | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is the cost of adding this
dev_ctx.Wait();?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have not make detailed test yet. But if we do not delete the step scope, we can not training a larger RNN model because of OutOfMemory.