fix the bug that dropout always use a fixed seed. #7979
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
lcy-seso force-pushed the fix_dropout branch 2 times, most recently from 9706ea1 to c3bccf6 Compare 
dzhwinter reviewed Jan 30, 2018
| | ||
| def dropout(x, dropout_prob, is_test=False, seed=0, **kwargs): | ||
| def dropout(x, dropout_prob, is_test=False, seed=None, **kwargs): | ||
| """ |
There was a problem hiding this comment.
it's better to set with 0. Our default value equals 0 in dropout op.
There was a problem hiding this comment.
If the seed is set to 0, it will be a fixed seed 0, not a random seed. So if I miss something?
There was a problem hiding this comment.
Here when the seed is set to None, a random seed will be used.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
fix #7796
fix_seedinstead of using seed=0 to represent using a random seed. By considering that currently an attribute must always be set and 0 is also a fixed seed.