Skip to content

Return unique_ptr of program desc in inference IO #7978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 30, 2018
Merged

Return unique_ptr of program desc in inference IO #7978

merged 1 commit into from
Jan 30, 2018

Conversation

@kexinzhao
Copy link
Contributor

This pr mainly address the comments on #7690 that for load() function, we need to return a unique_ptr of program desc.
@kexinzhao kexinzhao requested review from Xreki and sidgoyal78 January 30, 2018 10:13
@kexinzhao kexinzhao added the 预测 原名Inference，包含Capi预测问题等 label Jan 30, 2018
Xreki
Xreki approved these changes Jan 30, 2018
View reviewed changes
Copy link
Contributor

@Xreki Xreki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@Xreki Xreki merged commit db8da02 into PaddlePaddle:develop Jan 30, 2018
@kexinzhao kexinzhao deleted the fix_inference_load branch January 30, 2018 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

预测 原名Inference，包含Capi预测问题等

2 participants

@kexinzhao @Xreki