Add WMT16 into dataset. #7661
Merged
Add WMT16 into dataset. #7661
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
lcy-seso force-pushed the wmt16_en_ger branch 2 times, most recently from 6a387f6 to 0775d65 Compare 
lcy-seso force-pushed the wmt16_en_ger branch from 0775d65 to 9a97c7f Compare 
pkuyym requested changes Jan 20, 2018
python/paddle/v2/dataset/wmt16.py Outdated
| UNK_MARK = "<unk>" | ||
| | ||
| | ||
| def __build_dict__(tar_file, dict_size, save_path, lang): |
There was a problem hiding this comment.
Be careful about the naming style, since built-in functions in python are always named to __XXX__
There was a problem hiding this comment.
Yes, I agree. Do you think it is necessary to change the function named __xx__ into __xx also in other datasets (like wmt14) ?
There was a problem hiding this comment.
It seems that naming a function to _xx is enough to declare the function to be private. I have no idea whether __xx is a better naming style. It would be better to unify the naming style, however it is a tedious work.
There was a problem hiding this comment.
Thank you. According to Google style, https://google.github.io/styleguide/pyguide.html#Naming I think __xx is ok. I will have a try.
lcy-seso force-pushed the wmt16_en_ger branch from f2f583c to 2f344e7 Compare 
pkuyym approved these changes Jan 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
You can use this dataset like this: