Skip to content

Conversation

@Starrysea996
Copy link
Contributor

PR Category

User Experience

PR Types

New features

Description

add msort api for paddle, similar to torch.msort

[6. 9. 2. 6.]]]
"""

return assign(sort(x, axis=0), output)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

out参数目前统一不用管,后面会支持一个out机制,等sort支持后一起加上

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

可以先不用实现sort参数。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

好的

@PaddlePaddle PaddlePaddle locked and limited conversation to collaborators Aug 6, 2025
@PaddlePaddle PaddlePaddle unlocked this conversation Aug 6, 2025
@zhwesky2010 zhwesky2010 changed the title add msort api [API compatibility] add msort api Aug 6, 2025
@zhwesky2010 zhwesky2010 changed the title [API compatibility] add msort api [API compatibility]add msort api Aug 6, 2025
@zhwesky2010 zhwesky2010 changed the title [API compatibility]add msort api [API compatibility] add msort api Aug 6, 2025
Copy link
Contributor

@zhwesky2010 zhwesky2010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

先按没有out的情况完成吧

@Starrysea996
Copy link
Contributor Author

已经改为无out的情况

return out


def msort(x: Tensor) -> Tensor:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

使用input吧,和torch完全一致

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

参数已改为input

zhwesky2010
zhwesky2010 previously approved these changes Aug 7, 2025
Copy link
Contributor

@zhwesky2010 zhwesky2010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (develop@7404342). Learn more about missing BASE report.

Additional details and impacted files
@@ Coverage Diff @@ ## develop #74421 +/- ## =========================================== Coverage ? 100.00% =========================================== Files ? 1 Lines ? 2 Branches ? 0 =========================================== Hits ? 2 Misses ? 0 Partials ? 0 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
SigureMo
SigureMo previously approved these changes Aug 8, 2025
@Starrysea996 Starrysea996 dismissed stale reviews from SigureMo and zhwesky2010 via cfb83ae August 8, 2025 02:42
Copy link
Contributor

@XiaoguangHu01 XiaoguangHu01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhwesky2010 zhwesky2010 merged commit cb81162 into PaddlePaddle:develop Aug 8, 2025
72 of 73 checks passed
Enigmatisms pushed a commit to Enigmatisms/Paddle that referenced this pull request Aug 9, 2025
* add msort api * change msort api without out param * replace msort param x with input * change copyright time
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

5 participants