[CINN] Robustify min/max type matching #74316
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| 你的PR提交成功，感谢你对开源项目的贡献! |
lshpku approved these changes Jul 31, 2025
Enigmatisms added a commit to Enigmatisms/Paddle that referenced this pull request Aug 5, 2025
Enigmatisms added a commit to Enigmatisms/Paddle that referenced this pull request Aug 6, 2025
Enigmatisms added a commit to Enigmatisms/Paddle that referenced this pull request Aug 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
PR Category
CINN
PR Types
Bug fixes
Description
增补了一种情况下
未能考虑的问题。对应问题导致了6个模型出错（arange fusion之后引入的）。
方法很简单：判断min/max operand左右两边是否都存在 dynamic shape symbol，如果是，那就不能用比较弱的
ir::Cast，而必须使用ir::Call进行强制类型转换了。Pcard-89620