CINN Add more Simplify scenario: Select2MinMax, BoundSimplify, PowerL… #74292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| 你的PR提交成功，感谢你对开源项目的贡献! |
YuhanXu force-pushed the simplify_related_optim branch 12 times, most recently from f603b19 to cff0dd2 Compare 
zyfncg reviewed Aug 5, 2025
paddle/cinn/optim/ir_simplify.cc Outdated
| | ||
| using ir::ExprMutator<>::Visit; | ||
| | ||
| // 递归优化 Compare 操作数 |
| } | ||
| }; | ||
| | ||
| struct SimplifySelect2MinMaxMutator : public ir::ExprMutator<> { |
There was a problem hiding this comment.
新增用例在这里
test/cpp/pir/cinn/ir_simplify_select_test.cc
There was a problem hiding this comment.
可以在代码前加点注释写示例，方便阅读，大部分开发者想不到去看单测
| } | ||
| }; | ||
| | ||
| struct SimplifyPowerCeilLog2BitOpLdexpfMutator : public ir::ExprMutator<> { |
There was a problem hiding this comment.
新增用例在这里
test/cpp/pir/cinn/ir_simplify_test.cc
Comment on lines +546 to +571
| // 2. Match target pattern: pow(base, ceil(log2(x))) | ||
| if (op->name == "pow" && new_args.size() == 2) { | ||
| const Expr& base = new_args[0]; | ||
| const Expr& exponent = new_args[1]; |
There was a problem hiding this comment.
是算子逻辑运算，新增用例在这里
test/cpp/pir/cinn/ir_simplify_test.cc
实际场景里的输入ir是这样的
select-->min/max，power+log2 -->ldexpf+bitOp化简以后长这样
YuhanXu force-pushed the simplify_related_optim branch 4 times, most recently from 5bf17f4 to 882e5c4 Compare 
| /re-run all-failed |
liuruyan previously approved these changes Aug 7, 2025
paddle/cinn/optim/simplify_util.cc Outdated
Comment on lines 681 to 683
| const ir::IndexExpr &expr, const common::SymbolicExprAnalyzer &ana) { | ||
| // Handle cases like `(a * C1 + b) / C2` and `(a * C1 + b) % C2` | ||
| // where `C1` and `C2` are constants |
There was a problem hiding this comment.
这个注释描述不清晰，应描述c1、b、c2大小及倍数关系，并且添加相应辅助理解的case，可参考simplify_util.h
liuruyan reviewed Aug 7, 2025
paddle/cinn/optim/simplify_util.cc Outdated
Comment on lines 707 to 709
| if (rhs.is_constant() && rhs.as_int64() == denom_val) { | ||
| // Extract terms divisible by denominator | ||
| multiple_terms.push_back(term.operand(0)); // Extract multiplicand part |
There was a problem hiding this comment.
是否应该可以化简满足倍数关系？
Suggested change
| if (rhs.is_constant() && rhs.as_int64() == denom_val) { | |
| // Extract terms divisible by denominator | |
| multiple_terms.push_back(term.operand(0)); // Extract multiplicand part | |
| if (rhs.is_constant() && rhs.as_int64() % denom_val == 0) { | |
| // Extract terms divisible by denominator | |
| multiple_terms.push_back(term.operand(0) * (rhs.as_int64() / denom_va)); // Extract multiplicand part |
YuhanXu force-pushed the simplify_related_optim branch from 882e5c4 to d4a4336 Compare | /re-run all-failed |
liuruyan approved these changes Aug 11, 2025
zyfncg approved these changes Aug 11, 2025
Enigmatisms pushed a commit to Enigmatisms/Paddle that referenced this pull request Aug 11, 2025
maxiaolong001 pushed a commit to maxiaolong001/Paddle that referenced this pull request Aug 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
PR Category
CINN
PR Types
New features
Description
DeepSeek子网涉及到的一些Simplify优化:
SelectOp -> Min Max
BoundSimplify优化：支持 (ax + b)/a, a > b --> x, (ax + b)% a, a > b --> b,
“Power+Log”优化成“Bit操作+ldexpf"
明确CINN中UpperBound能否取到，修正UpperBound的传递关系，使其计算更准确
Var [LowerBound, UpperBound）左闭右开，
For loop_var [LowerBound, UpperBound）左闭右开，
CasInterval [LowerBound, UpperBound]左闭右闭，
SymbolicExprAnalyzer [LowerBound, UpperBound]左闭右闭
Pcard-90680