Skip to content

readd mkldnn api in paddle/fluid/inference/api/ [fluid_ops] #74230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 31, 2025
Merged

readd mkldnn api in paddle/fluid/inference/api/ [fluid_ops] #74230

merged 2 commits into from
Jul 31, 2025

Conversation

@co63oc
Copy link
Contributor

@co63oc co63oc commented Jul 24, 2025 •
edited
Loading

PR Category

User Experience

PR Types

Others

Description

已增加 paddle/fluid/inference/api/*.h下MKLDNN接口，其他ONEDNN接口逐渐增加
CI环境容易异常，修改多个PR提交
@paddle-bot
Copy link

paddle-bot bot commented Jul 24, 2025

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.
@paddle-bot paddle-bot bot added the contributor External developers label Jul 24, 2025
@gouzil gouzil removed their request for review July 24, 2025 13:31
@co63oc co63oc changed the title CI测试不review is_compiled_with_mkldnn Replace is_compiled_with_mkldnn is_compiled_with_onednn Jul 24, 2025
@co63oc
Copy link
Contributor Author

co63oc commented Jul 24, 2025

/re-run all-failed
@co63oc co63oc changed the title Replace is_compiled_with_mkldnn is_compiled_with_onednn Replace is_compiled_with_mkldnn is_compiled_with_onednn [fluid_ops] Jul 25, 2025
@co63oc
Copy link
Contributor Author

co63oc commented Jul 25, 2025

/re-run all-failed
@luotao1 luotao1 self-assigned this Jul 25, 2025
@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Jul 25, 2025
@co63oc
Copy link
Contributor Author

co63oc commented Jul 25, 2025

/re-run all-failed
@co63oc
Copy link
Contributor Author

co63oc commented Jul 25, 2025

/re-run all-failed
@codecov-commenter
Copy link

codecov-commenter commented Jul 26, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 0% with 33 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (develop@7ec9073). Learn more about missing BASE report.

Files with missing lines Patch % Lines
paddle/fluid/inference/api/paddle_pass_builder.cc 0.00% 20 Missing ⚠️
paddle/fluid/inference/capi_exp/pd_config.cc 0.00% 8 Missing ⚠️
paddle/fluid/inference/api/paddle_pass_builder.h 0.00% 5 Missing ⚠️

❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files 
@@ Coverage Diff @@ ## develop #74230 +/- ## ========================================== Coverage ? 0.00% ========================================== Files ? 3 Lines ? 33 Branches ? 0 ========================================== Hits ? 0 Misses ? 33 Partials ? 0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
@luotao1
Copy link
Contributor

luotao1 commented Jul 28, 2025 •
edited
Loading

@co63oc 关于PFCC群里提出的
9692789dff96e6b483a9df63b69f50bc
479e45a1e3cf94bccbeb0830bcee245e
7f7ebadc99845993ff6c6921bdbc57d6

和 @yuanlehome @qingqing01 推理研发商量后

  1. 原先接口保持不动，调用出给出废弃信息（将在4.0大版本进行废弃，dev版本 & 3.x系列版本两者共存），同时一一新增相应名称为onednn的接口，用于后续使用，文档一并更新。
  2. paddle/fluid/inference/api/ 目录下的 .h 文件中，所有涉及mkldnn的对外接口都采用上述方式。

cc @raoyutian 感谢指出！
@co63oc
Copy link
Contributor Author

co63oc commented Jul 28, 2025

@co63oc 关于PFCC群里提出的 9692789dff96e6b483a9df63b69f50bc 479e45a1e3cf94bccbeb0830bcee245e 7f7ebadc99845993ff6c6921bdbc57d6

和 @yuanlehome @qingqing01 推理研发商量后

  1. 原先接口保持不动，调用出给出废弃信息（将在4.0大版本进行废弃，dev版本 & 3.x系列版本两者共存），同时一一新增相应名称为onednn的接口，用于后续使用，文档一并更新。
  2. paddle/fluid/inference/api/ 目录下的 .h 文件中，所有涉及mkldnn的对外接口都采用上述方式。

cc @raoyutian 感谢指出！

好的收到
@co63oc
Copy link
Contributor Author

co63oc commented Jul 30, 2025

/re-run all-failed
@co63oc co63oc changed the title Replace is_compiled_with_mkldnn is_compiled_with_onednn [fluid_ops] readd mkldnn api in paddle/fluid/inference/api/ [fluid_ops] Jul 30, 2025
@co63oc
Copy link
Contributor Author

co63oc commented Jul 30, 2025

@luotao1 CI已完成
@yuanlehome
Copy link
Contributor

废弃api调用的时候，输出warning信息给用户说明什么时候废弃，建议调用什么api
@co63oc
Copy link
Contributor Author

co63oc commented Jul 30, 2025 •
edited
Loading

废弃api调用的时候，输出warning信息给用户说明什么时候废弃，建议调用什么api

已修改，有的接口在头文件，比如SetMKLDNNOp 在 paddle/fluid/inference/api/paddle_analysis_config.h，phi中头文件不允许包含glog/logging.h，没有修改增加提示
@co63oc
Copy link
Contributor Author

co63oc commented Jul 30, 2025

/re-run all-failed
@co63oc
Copy link
Contributor Author

co63oc commented Jul 31, 2025

@yuanlehome CI已完成需要review
@luotao1 luotao1 merged commit c6742c5 into PaddlePaddle:develop Jul 31, 2025
66 of 67 checks passed
@co63oc co63oc deleted the h58 branch August 1, 2025 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contributor External developers HappyOpenSource 快乐开源活动issue与PR

5 participants

@co63oc @codecov-commenter @luotao1 @yuanlehome @qingqing01