Skip to content

[0-size Tensor Job2 No.40、41] Add 0-size Tensor support for paddle.linalg.cholesky [fluid_ops] #74185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 24, 2025
Merged

[0-size Tensor Job2 No.40、41] Add 0-size Tensor support for paddle.linalg.cholesky [fluid_ops] #74185

merged 2 commits into from
Jul 24, 2025
+21 −3

Conversation

@co63oc
Copy link
Contributor

@co63oc co63oc commented Jul 23, 2025 •
edited
Loading

PR Category

Operator Mechanism

PR Types

Bug fixes

Description

40 paddle.linalg.cholesky
41 paddle.linalg.eigh

cholesky 增加输入参数验证，结尾两个维度应相等
eigh已有0-size单测，部分测试用例numpy error，增加输入参数验证，结尾两个维度应相等

numpy 测试

import numpy as np np.linalg.cholesky(np.random.random([2,0])) numpy.linalg.LinAlgError: Last 2 dimensions of the array must be square np.linalg.eigh(np.random.random([2,0])) numpy.linalg.LinAlgError: Last 2 dimensions of the array must be square

清理配置PR PFCCLab/PaddleAPITest#420
@paddle-bot
Copy link

paddle-bot bot commented Jul 23, 2025

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.
@paddle-bot paddle-bot bot added the contributor External developers label Jul 23, 2025
@co63oc co63oc mentioned this pull request Jul 23, 2025
Merged
@co63oc co63oc changed the title [0-size Tensor Job2 No.40、41] Add 0-size Tensor support for paddle.linalg.cholesky [0-size Tensor Job2 No.40、41] Add 0-size Tensor support for paddle.linalg.cholesky [fluid_ops] Jul 23, 2025
@luotao1 luotao1 added the HappyOpenSource Pro 进阶版快乐开源活动，更具挑战性的任务 label Jul 23, 2025
@luotao1 luotao1 mentioned this pull request Jul 23, 2025
Closed
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (develop@04080a8). Learn more about missing BASE report.

Additional details and impacted files 
@@ Coverage Diff @@ ## develop #74185 +/- ## =========================================== Coverage ? 100.00% =========================================== Files ? 1 Lines ? 3 Branches ? 0 =========================================== Hits ? 3 Misses ? 0 Partials ? 0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
@co63oc
Copy link
Contributor Author

co63oc commented Jul 23, 2025

/re-run all-failed
1 similar comment
@co63oc
Copy link
Contributor Author

co63oc commented Jul 23, 2025

/re-run all-failed
@co63oc
Copy link
Contributor Author

co63oc commented Jul 24, 2025

@DanielSun11 CI已完成需要review
DanielSun11
DanielSun11 approved these changes Jul 24, 2025
View reviewed changes
Copy link
Contributor

@DanielSun11 DanielSun11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@DanielSun11 DanielSun11 merged commit eb5c2be into PaddlePaddle:develop Jul 24, 2025
89 of 92 checks passed
@co63oc co63oc deleted the h48 branch July 26, 2025 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contributor External developers HappyOpenSource Pro 进阶版快乐开源活动，更具挑战性的任务

4 participants

@co63oc @codecov-commenter @DanielSun11 @luotao1