Skip to content

Conversation

@ooooo-create
Copy link
Contributor

@ooooo-create ooooo-create commented Jul 22, 2025

PR Category

Operator Mechanism

PR Types

Bug fixes

Description

对齐 torch 中 residuals 是否返回空向量的逻辑
https://github.com/pytorch/pytorch/blob/91b69deeb0f67a4b4ad7b36cdbb7d5f805b375a0/aten/src/ATen/native/BatchLinearAlgebra.cpp#L3510-L3535

只要 m>n 且不是 gelsy,且在输入是满秩矩阵时( driver == "gelss" || driver == "gelsd"),或者"gels" 会计算 residuals

@paddle-bot
Copy link

paddle-bot bot commented Jul 22, 2025

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@codecov-commenter
Copy link

codecov-commenter commented Jul 22, 2025

Codecov Report

Attention: Patch coverage is 82.05128% with 7 lines in your changes missing coverage. Please review.

Please upload report for BASE (develop@e73e32f). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...interface/infer_symbolic_shape/binary_infer_sym.cc 0.00% 7 Missing ⚠️

❌ Your patch status has failed because the patch coverage (82.05%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@ Coverage Diff @@ ## develop #74160 +/- ## ========================================== Coverage ? 82.05% ========================================== Files ? 4 Lines ? 39 Branches ? 0 ========================================== Hits ? 32 Misses ? 7 Partials ? 0 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
@ooooo-create ooooo-create marked this pull request as ready for review July 22, 2025 08:13
@ooooo-create ooooo-create changed the title Test [Accuracy diff No.102] Fix accuracy diff for paddle.lstsq API Jul 22, 2025
@luotao1 luotao1 added the HappyOpenSource Pro 进阶版快乐开源活动,更具挑战性的任务 label Jul 22, 2025
@ooooo-create
Copy link
Contributor Author

/re-run all-failed

@luotao1 luotao1 merged commit af08923 into PaddlePaddle:develop Jul 23, 2025
68 of 70 checks passed
@ooooo-create ooooo-create deleted the fix_lstsq branch September 29, 2025 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contributor External developers HappyOpenSource Pro 进阶版快乐开源活动,更具挑战性的任务 skip-ci: coverage

4 participants